Re: [PATCH 16/17] tools/kvm_stat: add interactive command 'r'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10.03.2017 12:37, Janosch Frank wrote:
>> @@ -757,10 +766,11 @@ class DebugfsProvider(object):
>>              self.paths = filter(lambda x: "{}-".format(pid) in x, vms)
>>
>>          else:
>> -            self.paths = ['']
>> +            self.paths = []
> 
> This is more a cleanup than new code, isn't it?

Not quite: The former holds an element, while the latter doesn't.
Therefore a subsequent 'for path in self.paths:' would execute with
the former version, but won't with the latter.

> [...]
>> @@ -1188,7 +1224,7 @@ Interactive Commands:
>>     g     filter by guest name
>>     p     filter by PID
>>     q     quit
>> -   x     toggle reporting of stats for individual child trace events
>> +   r     reset stats
>>  Press any other key to refresh statistics immediately.
>>  """
> 
> This is inconsistent to the part below.

Yup, accidental deletion - good catch, thanks!

Ciao,
Stefan




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux