Re: [PATCH V9 09/10] trace, ras: add ARM processor error trace event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/15/2017 10:47 AM, Steven Rostedt wrote:
On Wed, 15 Feb 2017 10:44:51 -0700
Tyler Baicar <tbaicar@xxxxxxxxxxxxxx> wrote:

Currently there are trace events for the various RAS
errors with the exception of ARM processor type errors.
Add a new trace event for such errors so that the user
will know when they occur. These trace events are
consistent with the ARM processor error section type
defined in UEFI 2.6 spec section N.2.4.4.

Signed-off-by: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx>
Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
---
  drivers/acpi/apei/ghes.c    |  8 +++++++-
  drivers/firmware/efi/cper.c |  1 +
  drivers/ras/ras.c           |  1 +
  include/ras/ras_event.h     | 34 ++++++++++++++++++++++++++++++++++
  4 files changed, 43 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index be365e2..560a172 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -514,7 +514,13 @@ static void ghes_do_proc(struct ghes *ghes,
  		}
  #endif
  #ifdef CONFIG_RAS
-		else if(trace_unknown_sec_event_enabled()) {
+		else if (!uuid_le_cmp(sec_type, CPER_SEC_PROC_ARM) &&
+			 trace_arm_event_enabled()) {
+			struct cper_sec_proc_arm *arm_err;
+
+			arm_err = acpi_hest_generic_data_payload(gdata);
+			trace_arm_event(arm_err);
+		} else if(trace_unknown_sec_event_enabled()) {
I think you want a space between "if" and "("

-- Steve
Oops :) I'll add that in.
  			void *unknown_err = acpi_hest_generic_data_payload(gdata);
  			trace_unknown_sec_event(&sec_type,
  					fru_id, fru_text, sec_sev,

--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux