Zhang, Xiantao wrote:
Avi Kivity wrote:
Zhang, Xiantao wrote:
Jes Sorensen wrote:
Hi,
The latest changes to qemu-kvm breaks miserably if one tries to
build without CONFIG_GDBSTUB.
Jes
--- qemu-kvm.orig/vl.c
+++ qemu-kvm/vl.c
@@ -4417,13 +4417,11 @@
}
if (cpu_can_run(env))
ret = qemu_cpu_exec(env);
-#ifndef CONFIG_GDBSTUB
^^^^^^^^^^^
Don't know why change #ifdef to #ifndef in upstream, and I remember
it should be ifdef before. I believe this stuff should be compiled
only if CONFIG_GDBSTUB is defined.
This was introduced by
commit 704aec581c1683750e313832ba3aa4813d59cbd0
Author: Xiantao Zhang <xiantao.zhang@xxxxxxxxx>
Date: Thu Nov 27 17:23:27 2008 +0800
Build fix for !CONFIG_GDBSTUB case
Once CONFIG_GDBSTUB not configured, compile will generate error
In upstream. Please fix it in upstream and qemu-kvm.git will get the
fix from there.
The original patch is 8c4379cc made by me in kvm-userspace.git and I used #ifdef, but accidently changed to #ifndef in qemu-kvm.git. So maybe this typo is introduced by Anthony Liguori when rewrote this patch for qemu-kvm.git ?
Xiantao
That commit got translated to fe538e6f in qemu-kvm.git.
Anthony, what's the reason for the difference between fe538e6f and 704aec58?
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
