Re: [patch] fix - do not build blobs when blobs are not needed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jes Sorensen wrote:
Hi,

Don't like ugly assembler errors because QEMU tries to build some x86
assembly code which isn't needed on non-x86.

.PHONY: kvm/extboot

+ifdef INSTALL_BLOBS
all: kvm/extboot

kvm/extboot:
@@ -427,3 +428,4 @@
           || ! cmp -s pc-bios/extboot.bin $@/extboot.bin; then \
		cp $@/extboot.bin pc-bios/extboot.bin; \
	fi
+endif
Index: qemu-kvm/configure
===================================================================
--- qemu-kvm.orig/configure
+++ qemu-kvm/configure
@@ -356,6 +356,7 @@
     cpu_emulation="no"
     gdbstub="no"
     slirp="no"
+     blobs="no"
fi
if [ "$cpu" = "powerpc" ]; then
     kvm="yes"


Seems a bit heavy handed.  blobs != extboot.

How about instead:

   build-targets-x86 = kvm/extboot

   all: $(build-targets-$(ARCH))

(or something similar that builds)

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux