Re: [patch 4/5] PTP: add PTP_SYS_OFFSET emulation via cross timestamps infrastructure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 20, 2017 at 01:55:27PM +0100, Paolo Bonzini wrote:
> 
> 
> On 20/01/2017 13:20, Marcelo Tosatti wrote:
> >  kernel/time/timekeeping.c        |   79 +++++++++++++++++++++++++++++++++++++++
> 
> Why not leave this in drivers/ptp/ptp_chardev.c?

timekeeper_lock

> > +		if (ptp->info->emulate_ptp_sys_offset_mean) {
> > +			err = emulate_ptp_sys_offset(ptp->info, sysoff, arg);
> > +			break;
> > +		}
> 
> I think this should be simply "if (!ptp->info->gettime64)" and,
> likewise, there should be an emulation based getcrosststamp in
> ptp_clock_gettime.
> 
> Paolo

gettime64 is called directly via ptp_clock_gettime.


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux