Paolo Bonzini <pbonzini@xxxxxxxxxx> writes:
> On 12/01/2017 18:32, Andrew Jones wrote:
>>>
>>> +# Any options left for QEMU?
>>> +shift $((OPTIND-1))
>>> +if [ "$#" -gt 0 ]; then
>>> + extra_opts="$@"
>>> +fi
>> We can unconditionally do the extra_opts="$@", extra_opts will just
>> be null in the case there aren't more args, like it was before.
>
> extra_opts is not an array, so this would mess up options that contain
> spaces. (Alex's patch in general, not your tweak).
Is it worth treating extra_opts as an array?
>
> Paolo
>
>>> +
>>> RUNTIME_log_stderr () { cat >> test.log; }
>>> RUNTIME_log_stdout () {
>>> if [ "$PRETTY_PRINT_STACKS" = "yes" ]; then
>>> @@ -59,4 +68,4 @@ RUNTIME_log_stdout () {
>>> config=$TEST_DIR/unittests.cfg
>>> rm -f test.log
>>> printf "BUILD_HEAD=$(cat build-head)\n\n" > test.log
>>> -for_each_unittest $config run
>>> +for_each_unittest $config run "$extra_opts"
--
Alex Bennée
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
