On Thu, Jan 12, 2017 at 01:29:52PM +0100, Paolo Bonzini wrote: > > > On 11/01/2017 17:28, Alex Bennée wrote: > > Signed-off-by: Alex Bennée <alex.bennee@xxxxxxxxxx> > > --- > > README.md | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/README.md b/README.md > > index 5027b62..9462824 100644 > > --- a/README.md > > +++ b/README.md > > @@ -79,3 +79,4 @@ You can add the following to .git/config to do this automatically for you: > > [format] > > subjectprefix = kvm-unit-tests PATCH > > > > +Please run the kernel's ./scripts/checkpatch.pl on new patches > > Does it really work well on kvm-unit-tests? I use it on new code (liberally ignoring stuff I don't think is worth conforming to), but there's no chance it'll work on old files (many lib files and pretty much all x86 files). So we can't really enforce for x86 developers, as we prefer consistency over kernel style. That said, I think mentioning in the README that new files could use it (at least for guidance) is a good idea. Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
