On 11/01/2017 15:19, Andrew Jones wrote:
> This patch reverts the stty parts of 8727c886 "runtime: better
> handling of QEMU aborts", as we can more robustly fix the same
> issue by simply redirecting /dev/null into qemu's stdin. The
> obvious side effect of this is that serial input will no longer
> be wired up to the tty (or any other input file descriptor), but
> unit tests do not, and should not, be reading from the serial port
> anyway.
>
> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx>
> ---
> scripts/arch-run.bash | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash
> index 92fac8cf5f96..1610f3b2e6a6 100644
> --- a/scripts/arch-run.bash
> +++ b/scripts/arch-run.bash
> @@ -26,15 +26,13 @@
> ##############################################################################
> run_qemu ()
> {
> - local stdout errors ret sig tty
> + local stdout errors ret sig
>
> # stdout to {stdout}, stderr to $errors and stderr
> - tty=$(stty -g)
> exec {stdout}>&1
> - errors=$("${@}" 2> >(tee /dev/stderr) > /dev/fd/$stdout)
> + errors=$("${@}" </dev/null 2> >(tee /dev/stderr) > /dev/fd/$stdout)
> ret=$?
> exec {stdout}>&-
> - stty "$tty"
>
> [ $ret -eq 134 ] && echo "QEMU Aborted" >&2
>
>
Queued, thanks.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
