Re: [kvm-unit-tests PATCH] x86: apic: add physical broadcast test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 22/12/2016 19:15, Radim Krčmář wrote:
> 2016-12-22 11:45+0100, Paolo Bonzini:
>> On 19/12/2016 17:04, Radim Krčmář wrote:
>>> Broadcast to address 0xff is not exercised by seabios+linux so we better
>>> test it.
>>>
>>> Signed-off-by: Radim Krčmář <rkrcmar@xxxxxxxxxx>
>>> ---
>>
>> This test is broken by
>>
>>     commit f11e8b051ef613670f9db77a79726534dbc667ec
>>     Author: Radim Krčmář <rkrcmar@xxxxxxxxxx>
>>     Date:   Tue Dec 13 17:30:00 2016 +0100
>>
>>     KVM: x86: make interrupt delivery fast and slow path behave the same
>>     
>>     Slow path tried to prevent IPIs from x2APIC VCPUs from being delivered
>>     to xAPIC VCPUs and vice-versa.  Make slow path behave like fast path,
>>     which never distinguished that.
>>     
>>     Signed-off-by: Radim Krčmář <rkrcmar@xxxxxxxxxx>
>>     Fixes: 682f732ecf73 ("KVM: x86: bump MAX_VCPUS to 288")
>>     Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>>
>> when run with "./x86/run x86/apic.flat -smp 2 -cpu Nehalem,-x2apic", so I'm removing
>> that series from kvm/queue.
> 
> Yes, kvm/queue had v2 of the series and I have added the test because
> David noticed the broadcast bug while reviewing v3 of that series.
> (http://www.spinics.net/lists/kvm/msg142614.html)
> 
> The bug was fixed in v4.  I have only posted v4 of this one patch as the
> rest seemed ok in v3.

Oh, okay, then I'll recheck and fix it.

Currently I'm seeing WinXP/2003 failures with apicv=0 and Win2008r2
failures with apicv=0 ept=0.  I guess I'll have to have some fun bisecting.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux