On 20/12/2016 10:48, David Hildenbrand wrote: >> >> __clear_sp_write_flooding_count(sp); >> - trace_kvm_mmu_get_page(sp, false); >> - return sp; >> + created = false; > > Simply doing > > if (collisions > vcpu->kvm->stat.max_mmu_page_hash_collisions) > vcpu->kvm->stat.max_mmu_page_hash_collisions = collisions; > > at this point saves a local variable, a jump label and keeps this patch > minimal. How so? There is a "break" above. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html