On Thursday, December 15, 2016 03:20:19 PM Xiao Guangrong wrote: > Why not include lockless_walk into the loop, retry 4 times for a invalid sp is expensive. Yes, we can move the page table walk inside the loop as well. But I’m sorry I don’t fully understand how an invalid sp will lead to retrying 4 times. Could you please elaborate a bit? Wouldn’t we break out of the loop in that case? Or do you mean the case when a huge page is getting broken down or built up? > I am curious that did you see this retry is really helpful? :) No, I haven’t done a comparison with and without the retries since it seemed to be a fairly simple optimization. And it may not be straightforward to reliably reproduce the situation where it will help. Thanks, Junaid -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
