cpu_init must be called before mem_init because cpu_init determines the cache-line sizes. Currently io_init has no dependency on mem_init, but io_init should be allowed to use heap allocation, and someday it may, so we proactively comment it. Cc: Laurent Vivier <lvivier@xxxxxxxxxx> Cc: Thomas Huth <thuth@xxxxxxxxxx> Signed-off-by: Andrew Jones <drjones@xxxxxxxxxx> --- lib/powerpc/setup.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/powerpc/setup.c b/lib/powerpc/setup.c index 9153f7bebc6a..0e776235e22d 100644 --- a/lib/powerpc/setup.c +++ b/lib/powerpc/setup.c @@ -168,7 +168,11 @@ void setup(const void *fdt) assert(ret == 0); cpu_init(); + + /* cpu_init must be called before mem_init */ mem_init(PAGE_ALIGN((unsigned long)&stacktop + fdt_size)); + + /* mem_init must be called before io_init */ io_init(); ret = dt_get_bootargs(&bootargs); -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
