Re: [PATCH v2] kvm: nVMX: Correct a VMX instruction error code for VMPTRLD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Just one, I think: [kvm-unit-tests PATCH] Test 32-bit ljmp emulation.

On Thu, Dec 8, 2016 at 7:27 AM, Radim Krčmář <rkrcmar@xxxxxxxxxx> wrote:
> 2016-12-05 15:31+0100, David Hildenbrand:
>> Am 30.11.2016 um 19:28 schrieb Jim Mattson:
>>> From: GanShun <ganshun@xxxxxxxxxx>
>>>
>>> When the operand passed to VMPTRLD matches the address of the VMXON
>>> region, the VMX instruction error code should be
>>> VMXERR_VMPTRLD_VMXON_POINTER rather than VMXERR_VMCLEAR_VMXON_POINTER.
>>>
>>> Signed-off-by: Jim Mattson <jmattson@xxxxxxxxxx>
>>> ---
>>>  arch/x86/kvm/vmx.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>>> index 0c4cde8..a1c7a43 100644
>>> --- a/arch/x86/kvm/vmx.c
>>> +++ b/arch/x86/kvm/vmx.c
>>> @@ -6960,7 +6960,7 @@ static int nested_vmx_check_vmptr(struct kvm_vcpu *vcpu, int exit_reason,
>>>
>>>              if (vmptr == vmx->nested.vmxon_ptr) {
>>>                      nested_vmx_failValid(vcpu,
>>> -                                         VMXERR_VMCLEAR_VMXON_POINTER);
>>> +                                         VMXERR_VMPTRLD_VMXON_POINTER);
>>>                      skip_emulated_instruction(vcpu);
>>>                      return 1;
>>>              }
>>>
>>
>> VMXERR_VMPTRLD_VMXON_POINTER was completely unused so far. This is correct
>> (Vol. 3C 30-16 and 30-29).
>>
>> Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>
>
> Jim, I don't see your emails on the list (that don't Cc me) after Nov 4.
> Have you posted more than this patch and the checkpoint/restore series?
> ([PATCH 0/8] kvm: nVMX: Checkpoint/restore support for VMX state)
>
> I'm sorry they fell through cracks.
> (Still no idea why -- filters don't even delete mail.)
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux