Re: [PATCH 1/5] kvm/x86: fix inversed check for async_pf MSR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index bf11fe4..14a46e9 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -8402,7 +8402,7 @@ void kvm_arch_async_page_present(struct kvm_vcpu *vcpu,
> bool kvm_arch_can_inject_async_page_present(struct kvm_vcpu *vcpu)
> {
> 	if (!(vcpu->arch.apf.msr_val & KVM_ASYNC_PF_ENABLED))
> -		return true;
> +		return false;
> 
> 
Why do you make this change? I think kvm_arch_async_page_present() is not
ever called now and neither kvm_del_async_pf_gfn(vcpu, work->arch.gfn);
 
Even with !KVM_ASYNC_PF_ENABLED the pf is handled with the workqueue asynchronously.

> 
> 
>> 	else
>> 		return !kvm_event_needs_reinjection(vcpu) &&
>  			kvm_x86_ops->interrupt_allowed(vcpu);
> 
 --Mika
 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux