Re: [PATCH] kvm: x86: Allow PIT emulation without speaker port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jan Kiszka wrote:
The in-kernel speaker emulation is only a dummy and also unneeded from
the performance point of view. Rather, it takes user space support to
generate sound output on the host, e.g. console beeps.

To allow this, introduce KVM_CREATE_PIT_NOSPKR which is simply
KVM_CREATE_PIT without registration of the speaker_dev.


Nothing wrong with the patch, but let's make it a little more forward looking. Have a CREATE_PIT2 (or something) which accepts a structure with a flags field and some padding. Define the first flag as speaker in kernel vs speaker in userspace.

This would allow us to hack the PIT some more in the future if we find we need too.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux