Hi Andre, Did you have a chance to look at the patch? I did not do any additional testing. If you specify what particular tests you mean I am willing to run it. Are you planing to forward this patch upstream or you want me to do that? Regards, Dejan ________________________________________ From: Andre Przywara [andre.przywara@xxxxxxx] Sent: Monday, June 20, 2016 11:13 AM To: Riku Voipio; Dejan Latinovic; 827525@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx Subject: Re: Bug#827525: kvmtool: FTBFS on mips64el: guest/guest_init.o: linking 32-bit code with 64-bit code Hi, (thanks Riku for forwarding this!) On 17/06/16 19:31, Riku Voipio wrote: > On 17 June 2016 at 15:04, Dejan Latinovic <Dejan.Latinovic@xxxxxxxxxx> wrote: >> Package kvmtool FTBFS for mips64el with the following error: >> >>> LINK lkvm >>> /usr/bin/ld: guest/guest_init.o: warning: linking abicalls files with non-abicalls files >>> /usr/bin/ld: guest/guest_init.o: linking 32-bit code with 64-bit code >>> /usr/bin/ld: failed to merge target specific data of file guest/guest_init.o >>> collect2: error: ld returned 1 exit status >>> Makefile:381: recipe for target 'lkvm' failed >>> make[1]: *** [lkvm] Error 1 >> >> Full build log: >> https://buildd.debian.org/status/fetch.php?pkg=kvmtool&arch=mips64el&ver=0.20160419-1&stamp=1463209003 >> >> The reason for that is behaviour is the way of creation guest_init.o. >>> ld -r -b binary -o guest/guest_init.o guest/init >> >> Resulting file is "MIPS-I" instead of expected "MIPS64 rel2". >>> file guest/guest_init.o.cp >>> guest/guest_init.o.cp: ELF 64-bit LSB relocatable, MIPS, MIPS-I version 1 (SYSV), not stripped >> >> If options "-r -b binary" are used, linker will ignore flags of input file "Flags: 0x80000006, pic, cpic, mips64r2", >> and flags of resulting guest_init.o file will be "Flags: 0x0". >> >> Solution for this issue could be using different method for creation guest_init.o. >> If xxd and gcc are used instead of ld, resulting file will have regular flags. >>> xxd -i guest/init | $(CC) -c -x c - -o guest/guest_init.o >> Here are proposed changes for this issue. >> http://www.spinics.net/lists/kvm/msg118016.html >> >> I have created a patch that fixes this issue modeled on mentioned solution. >> Using this patch I was able to build kvmtool for mips64el, mipsel, i386, amd64. >> The patch is attached. >> Could you please consider including this patch. > > I think the patch is better applied directly upstream, I'm sure there > are non-Debian users who would like to use kvmtool on mips64el. Dejan, do you have a mean of actually _testing_ this? I haven't seen a kvmtool/MIPS user for a while (also the build is broken for ages), so I am curious ... Let me take a look and revive this old patch, which needs some adjustments due to the new (pre-)init code. Cheers, Andre. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
