On Sun, Nov 27, 2016 at 11:54:46AM +0100, Alexander Gordeev wrote:
> On Wed, Nov 23, 2016 at 06:57:31PM +0800, Peter Xu wrote:
> > +void edu_dma(struct pci_edu_dev *dev, iova_t iova,
> > + size_t size, int dev_offset, bool from_device)
> > +{
> > + uint64_t from, to;
> > + uint32_t cmd = EDU_CMD_DMA_START;
> > +
> > + assert(size <= EDU_DMA_SIZE_MAX);
> > + assert(dev_offset < EDU_DMA_SIZE_MAX &&
> > + dev_offset >= 0);
>
> Any reason for dev_offset not to be unsigned?
No specific reason (though logically it can be <0 value, since it'll
be by default shifted by EDU_DMA_START later). I can switch to
unsigned if there is any further repost. Thanks,
-- peterx
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
