Re: [kvm-unit-tests PATCH] report: introduce report_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2016-11-18 15:26+0100, Andrew Jones:
> On Fri, Nov 18, 2016 at 03:20:24PM +0100, Thomas Huth wrote:
>> On 18.11.2016 14:35, Andrew Jones wrote:
>> > Test writers sometimes want to output informational messages, but
>> > they don't want to use printf because they want the prefixes as
>> > well. Rather than creating "fake" tests that always pass, with
>> > report(fmt, true, ...), provide report_info(fmt, ...). This
>> > generates 'INFO: prefixes...: message'
>> > 
>> > While touching report code also add the lock to report_abort to
>> > ensure its output line integrity.
>> 
>> Since repor_abort() is a different topic, I'd suggest to move that hunk
>> into a different patch instead.
> 
> Yeah, I was being a big lazy there. I can respin with lazy-mode disabled,
> if you like, but I'll stay lazy just a little longer to see if Radim/Paolo
> take it as is :-)

I'd prefer two patches as well.  Laziness is good, though ...
If you stay lazy for more than a week from now, I'll apply v1 with a
note that we all agreed that this is not how patches should be split.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux