Re: [PATCH kvm-unit-tests v5 01/14] pci: fix missing extern for pci_testdev()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 15, 2016 at 05:24:56PM -0500, Peter Xu wrote:
> Suggested-by: Andrew Jones <drjones@xxxxxxxxxx>
> Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>
> ---
>  lib/pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/pci.h b/lib/pci.h
> index 30f5381..86d6b42 100644
> --- a/lib/pci.h
> +++ b/lib/pci.h
> @@ -43,7 +43,7 @@ extern bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
>  extern void pci_bar_print(pcidevaddr_t dev, int bar_num);
>  extern void pci_dev_print_id(pcidevaddr_t dev);
>  
> -int pci_testdev(void);
> +extern int pci_testdev(void);
>  
>  /*
>   * pci-testdev is a driver for the pci-testdev qemu pci device. The
> -- 
> 2.7.4
>

I would have allowed this change to be slipped in with the addition
of new declarations, i.e. no need for its own patch, but anyway

Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux