On Fri, Nov 11, 2016 at 03:17:25PM +0000, Andre Przywara wrote: > > > > This doesn't seem to be used and I'm not sure what GICD_TYPER_IRQS it is > > trying to achieve. > > The idea is to calculate the number of implemented SPIs. But I am not a > big fan of copying a macro from the emulation code base to the test code. > Consider it rewritten then :-) I did review the spec while copying over stuff from Linux, so Linux has been getting a review at the same time. I agree that we should be cautious with copy+paste and we should probably not bring over super complex macros that are hard to understand, because we want kvm-unit-tests to be easy to read. Let's not say "no macros from Linux", but rather case-by-case it. I think this macro is a nice addition to our little API. Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
