On Fri, Nov 11, 2016 at 11:13:46AM +0000, Andre Przywara wrote: > Hi, > > more a comment loosely related to this patch ... > > > diff --git a/arm/unittests.cfg b/arm/unittests.cfg > > index 3f6fa45c587e..68bf5cd6008f 100644 > > --- a/arm/unittests.cfg > > +++ b/arm/unittests.cfg > > @@ -54,3 +54,10 @@ file = selftest.flat > > smp = $MAX_SMP > > extra_params = -append 'smp' > > groups = selftest > > + > > +# Test GIC emulation > > +[gicv2-ipi] > > +file = gic.flat > > +smp = $((($MAX_SMP < 8)?$MAX_SMP:8)) > > So here we always go with the maximum number of VCPUs in the guest. > However (as you also noted in your cover-letter) running with a > different number of CPUs might be interesting, for instance with less > than 8 CPUs on a GICv2 (the ITARGETSR register must be masked) or in > general with an odd number (both literally and in the broader sense). I > have a test case with passes with 8 VCPUs but fails with less. > > Is there any good way to run some tests multiple times with different > numbers of VCPUS? > Shall we add some "set" functionality to the smp parameter, so that we > can specify a list of desired test points? > We can just add multiple entries, e.g. [gicv2-ipi] file = gic.flat smp = $((($MAX_SMP < 8)?$MAX_SMP:8)) [gicv2-ipi-3] file = gic.flat smp = $((($MAX_SMP > 3)?3:$MAX_SMP)) or whatever. But we need to always consider MAX_SMP, since some machines may less than 8. Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
