Agreed, but as you can probably tell, I don't use QEMU, so I will
leave that to someone who does.
On Wed, Nov 9, 2016 at 9:37 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
>
> On 09/11/2016 18:28, Jim Mattson wrote:
>> Better would be to call kvm_update_cpuid regardless, I think.
>
> Sure. A kvm-unit-tests patch would be even better so that we can ensure
> it works with QEMU userspace irqchip. :)
>
> Paolo
>
>> On Wed, Nov 9, 2016 at 9:14 AM, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>>>
>>>
>>> On 09/11/2016 18:04, Jim Mattson wrote:
>>>>
>>>> + best->edx &= ~F(APIC);
>>>> + if (vcpu->arch.apic_base & MSR_IA32_APICBASE_ENABLE)
>>>> + best->edx |= F(APIC);
>>>> +
>>>> if (apic) {
>>>> if (best->ecx & F(TSC_DEADLINE_TIMER))
>>>> apic->lapic_timer.timer_mode_mask = 3 << 17;
>>>
>>> The three new lines should be inside "if (apic)", because you are not
>>> calling kvm_update_cpuid at all in kvm_lapic_set_base's "if (!apic)" case.
>>>
>>> Thanks,
>>>
>>> Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
