On Tue, 8 Nov 2016, Borislav Petkov wrote: > On Tue, Nov 08, 2016 at 04:52:27PM +0800, He Chen wrote: > > +struct cpuid_regs { > > + u32 eax, ebx, ecx, edx; > > +}; > > Why do you export this? It is used in cpuid.c only. Because I asked for it. We should have this stuff in one place to avoid the next name clash. What's worse with that patch is, that it does two things in one go: - cleanup that whole cpuid_regs mess - add the new function That should clearly be seperated into two patches. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html