On Mon, Nov 07, 2016 at 09:44:39AM +0100, Andrew Jones wrote: > On Sat, Nov 05, 2016 at 06:25:44PM +0100, Alexander Gordeev wrote: > > > Another note on this PCI_COMMAND write. Why is it safe [correct?] to > > > use writel? This is a 16-bit register according to the comment in > > > lib/linux/pci_regs.h. Don't we need to introduce a pci_config_writew > > > and use that? If so, then you should grab Peter Xu's patch that > > > introduces pci_config_writeb/w. > > > > You are right, this is cleanly a bug. > > > > However, I can not put Peter's patch neither before nor after mine, > > since pci_config_write*() are both introduced and used in this patch. > > As Peter's patch needs a refreshment anyway (see my comment on it) > > I will add pci_config_writew() to this patch. Hope, that works for > > everyone. > > It's a trivial patch, so I guess Peter would be fine with you just > doing it however it works best for this series, and then he'll drop > his patch. Yeah, please. I'll drop mine. Thanks, -- peterx -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
