Re: [kvm-unit-tests PATCH v10 10/12] pci: Add generic ECAM host support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 07, 2016 at 08:56:39AM +0100, Alexander Gordeev wrote:
> +
> +		cmd = PCI_COMMAND_SERR | PCI_COMMAND_PARITY;
> +

I don't think the parity error response bit is necessary for
virtual (qemu emulated) devices. I'd also rather minimize
the amount of setup we do for devices here, leaving most of
the setup to the unit tests that want to drive the devices.
IOW, I wouldn't bother with the parity thing, and, IMO, if
we can't allocate resources here, for whatever reason, then
we shouldn't touch the device at all; we should just leave
it to the unit tests.

Since we're just down to a couple of tweaks that should apply
to your v9, then I'll just do them and send Paolo a pull
request.

Thanks for all your work on this!

Thanks,
drew
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux