Re: [PATCH 0/2] extend page_track for external usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2016.11.04 12:22:14 +0100, Paolo Bonzini wrote:
> >>>> On 25/10/2016 09:50, Jike Song wrote:
> >>>>> page_track is currently used only by KVM internally to protect guest
> >>>>> page tables. To be used by external user like KVMGT, the callbacks
> >>>>> should carry more information other than KVM/VCPU, and the symbols
> >>>>> should be exported.
> >>>>>
> >>>>> Jike Song (2):
> >>>>>   kvm/page_track: call notifiers with kvm_page_track_notifier_node
> >>>>>   kvm/page_track: export symbols for external usage
> >>>>>
> >>>>>  arch/x86/include/asm/kvm_page_track.h | 7 +++++--
> >>>>>  arch/x86/kvm/mmu.c                    | 6 ++++--
> >>>>>  arch/x86/kvm/page_track.c             | 8 ++++++--
> >>>>>  3 files changed, 15 insertions(+), 6 deletions(-)
> >>>>
> >>>> Thanks, applied to kvm/queue.
> >>>>
> >>>> Paolo
> >>>>
> >>>
> >>> Hi Paolo,
> >>>
> >>> I just synced kvm repo and it seemd there was a forced-update on
> >>> kvm/queue, and the commits are dropped? 
> >>
> >> I temporarily reverted everything after the APICv patches.  They'll be
> >> back soon (and in kvm/next).
> > 
> > Paolo, for this case, do you think it's feasible we pick them through
> > drm/i915 merge path? As currently initial KVMGT patch sets require these
> > exported symbols, that's why I ask how we should handle this dependency.
> 
> Then it's actually a good thing that I dropped from kvm/queue!  You can
> certainly include these patches, but please do that through a topic branch.
> 
> I've prepared a branch for you
> (git://git.kernel.org/pub/scm/virt/kvm/kvm.git branch for-kvmgt).  Once
> Linus processes my outstanding pull request, the branch will only
> include the three page-tracking patches.  Please pull that topic branch
> into your own branch, and ensure you have a merge commit when you send
> the pull request to Daniel.  The merge commit ensures that the workflow
> was correct; use --no-ff if necessary.
>

Thanks a lot, Paolo! It looks good to me.

> You can do the same for Jike's patches for the KVM-VFIO device, when
> Alex reviews them, and I suppose you'll need a topic branch for mdev
> too?  I didn't know that KVMGT was planned for 4.10.  In the future,
> let's synchronize ahead so that we can prepare topic branches for you.
>

yeah, will need Jike's KVM instance patch too, but depends on VFIO/mdev
to land first I think, will need a topic branch for sure.

Our current KVMGT testing turns out good for 4.10 and we're trying to
push that. Sorry that we've ignored to sync with KVM side as we might
assume required change will be surely ready for 4.10. ;) We'll prepare
and notify earlier in future.

Thanks

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux