On Fri, Nov 04, 2016 at 08:36:05AM +0100, Thomas Huth wrote: > On 03.11.2016 21:30, Christoph Hellwig wrote: > > Why? The extern keyword for function prototypes is a no-op. > > It's used in many of the kvm-unit-test header files already, so I guess > the code looks a little bit more consistent this way. Yeah, it's a bit of an annoying, historic trait of kvm-unit-tests. Until we do a big extern removing patch to clean those up, then I prefer we keep things consistent. Thanks, drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html