2016-10-21 2:10 GMT+08:00 Radim Krčmář <rkrcmar@xxxxxxxxxx>: > 2016-10-20 06:57+0800, Wanpeng Li: >> 2016-10-20 3:28 GMT+08:00 Radim Krčmář <rkrcmar@xxxxxxxxxx>: >>> I think it would be better to add a function to advance the periodic >>> timer and use it in kvm_lapic_expired_hv_timer() and in apic_timer_fn(). >>> >>> The function can be simpler than set_target_expiration(), because it >>> just adds the period to an existing timer. Periodic timer will also be >>> better then, because the period will not depend on KVM's latency when >>> rearming. >> >> Good point, what's the function name do you like? How about >> advance_target_expiration()? > > Sounds good, I'd just slap periodic somewhere, > advance_periodic_target_expiration()? Cool, thanks for your review. :) Regards, Wanpeng Li -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html