[meta-comment]
On 10/18/2016 09:32 PM, Jike Song wrote:
> On 10/18/2016 10:59 PM, Alex Williamson wrote:
...
>>>>>>>>>>>>>>> On 10/10/2016 20:01, Neo Jia wrote:
>>>>>>>>>>>>>>>>> Hi Neo,
17 levels of quoting is rather over-the-top. It is OKAY (and in fact
DESIRABLE) to trim your emails to relevant portions, when posting to a
high-volume list. Readers shouldn't have to scroll through pages of
deeply-nested quoting...
>>>
>>> mutex_lock(&vfio.group_lock);
>>> list_for_each_entry(group, &vfio.group_list, vfio_next) {
>>> if (group->iommu_group == iommu_group) {
>>> - vfio_group_get(group);
>>
>> This is wrong, we can't add our reference after we release the lock.
>>
>
> Thanks for pointing it out :)
>
...to get to the much smaller meat of the message.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
