Hollis Blanchard wrote:
On Thu, 2009-04-23 at 18:40 +0300, Avi Kivity wrote:
Still missing:
- I have not tested powerpc or ia64. Patches welcome!
This repository seems pretty messed up; I'm not even sure what you want
from me. Some of the bigger problems:
* configure completely ignores --kerneldir and only uses
kvm/kernel headers instead.
That's intentional.
* The headers in kvm/kernel/arch/foo seem to be the important
ones, but they have odd ifdefs at the top and I'm not sure how
they should be generated.
They were generated by the old 'make sync' to remove CONFIG_
dependencies. I guess a better way to generate them is a 'make
headers-install' from the kernel tree and grab the results.
* "make -C kvm/kernel sync" doesn't even come close to working.
One of the goals of qemu-kvm.git was to have a standalone repository so
I could release kvm-kmod and qemu-kvm independently.
There are a host of other issues and confusing issues, even with a fresh
checkout. In general it seems like the mess that was kvm-userspace has
been rearranged, and as a consequence is even worse than before.
Can you detail specific grievances? Please exclude temporary brokenness
that was the result of the change.
How am I supposed to create kvm/kernel/arch/powerpc/include/asm/*? Just
cp from a Linux tree, or must I add funny ifdefs somehow?
cp from a Linux tree won't compile. The results of the old 'make sync'
would do, but a 'make headers-install' is probably better.
Here's one patch that I think will be needed:
Set kvm_arch=powerpc for PPC builds.
The name of the Linux arch directory is "powerpc", not "ppc".
Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
diff --git a/configure b/configure
index fc0fb9b..257cf02 100755
--- a/configure
+++ b/configure
@@ -816,6 +816,9 @@ case "$cpu" in
i386 | x86_64)
kvm_arch="x86"
;;
+ ppc)
+ kvm_arch="powerpc"
+ ;;
*)
kvm_arch="$cpu"
;;
Applied, thanks.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
