On Fri, 14 Oct 2016 09:01:01 +0530 Kirti Wankhede <kwankhede@xxxxxxxxxx> wrote: > On 10/13/2016 8:06 PM, Alex Williamson wrote: > > On Thu, 13 Oct 2016 14:52:09 +0530 > > Kirti Wankhede <kwankhede@xxxxxxxxxx> wrote: > > > >> On 10/13/2016 3:14 AM, Alex Williamson wrote: > >>> Under the device we have "mtty2", shouldn't that be > >>> "mdev_supported_type", which then links to mtty2? Otherwise a user > >>> needs to decode from the link what this attribute is. > >>> > >> > >> I thought it should show type, so that by looking at 'ls' output user > >> should be able to find type_id. > > > > The type_id should be shown by actually reading the link, not by the > > link name itself, the same way that the iommu_group link for a device > > isn't the group number, it links to the group number but uses a > > standard link name. > > > > Ok. I'll rename the link name to 'mdev_supported_type' Hmm, if we have a device, then clearly it's a supported type, we can probably reduce this to 'mdev_type'. Sorry for not catching that. BTW, please include the linux-kernel <linux-kernel@xxxxxxxxxxxxxxx> mailing list on the CC in your next posting. Thanks, Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html