Re: [PATCH] hmp: fix qemu crash due to ioapic state dump w/ split irqchip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 23/09/2016 05:47, Wanpeng Li wrote:
> From: Wanpeng Li <wanpeng.li@xxxxxxxxxxx>
> 
> The qemu will crash when info ioapic through hmp if irqchip 
> is split. Below message is splat:
> 
> KVM_GET_IRQCHIP failed: Unknown error -6
> 
> This patch fix it by dumping the ioapic state from the qemu 
> emulated ioapic if irqchip is split.
> 
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: Richard Henderson <rth@xxxxxxxxxxx>
> Cc: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> Signed-off-by: Wanpeng Li <wanpeng.li@xxxxxxxxxxx>
> ---
>  target-i386/monitor.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/target-i386/monitor.c b/target-i386/monitor.c
> index fccfe40..bf1e983 100644
> --- a/target-i386/monitor.c
> +++ b/target-i386/monitor.c
> @@ -504,7 +504,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict)
>  
>  void hmp_info_io_apic(Monitor *mon, const QDict *qdict)
>  {
> -    if (kvm_irqchip_in_kernel()) {
> +    if (kvm_irqchip_in_kernel() &&
> +        !kvm_irqchip_is_split()) {
>          kvm_ioapic_dump_state(mon, qdict);
>      } else {
>          ioapic_dump_state(mon, qdict);
> 

Queued, thanks.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux