Hi,
Your series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1473822299-6302-1-git-send-email-wanpeng.li@xxxxxxxxxxx
Subject: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9bcacc6 pc: apic: fix touch LAPIC when irqchip is split
=== OUTPUT BEGIN ===
Checking PATCH 1/1: pc: apic: fix touch LAPIC when irqchip is split...
ERROR: suspect code indent for conditional statements (4, 9)
#90: FILE: hw/i386/pc.c:164:
+ if (!kvm_irqchip_in_kernel()) {
+ intno = apic_get_interrupt(cpu->apic_state);
ERROR: suspect code indent for conditional statements (9, 13)
#92: FILE: hw/i386/pc.c:166:
+ if (intno >= 0) {
+ return intno;
ERROR: suspect code indent for conditional statements (9, 13)
#96: FILE: hw/i386/pc.c:170:
+ if (!apic_accept_pic_intr(cpu->apic_state)) {
+ return -1;
total: 3 errors, 0 warnings, 30 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxxxxx��.n��������+%������w��{.n�����o�^n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�
