On Wed, 24 Aug 2016 20:36:26 +0200 SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> wrote: > From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > Date: Wed, 24 Aug 2016 19:45:23 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus reuse the corresponding function "kmalloc_array". > > Suggested-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > This issue was detected also by using the Coccinelle software. Do you have the scripts you use published somewhere? > > * Replace the specification of data structures by pointer dereferences > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > * Delete the local variable "size" which became unnecessary with > this refactoring. I think your description is a bit on the verbose side, but not enough to gripe more. > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> > --- > > v2: Rebased on source files from "Linux next-20160824". > Advices were integrated from source code review. > > arch/s390/kvm/guestdbg.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) Acked-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
