On 13.08.2016 09:20, Paolo Bonzini wrote: > On 13/08/2016 00:07, Alexander Popov wrote: >> I.e. our irq_mask()/irq_unmask() callbacks get irq_desc of the interrupt >> which should be masked/unmasked and can ask the hypervisor to stop/start >> injecting the vector of that particular interrupt. > > So just let the irqdomain know about your hypervisor and avoid the > pointless indirection through function pointers, and only call > arch_init_paravirq_domain in a file specific to your hypervisor. Paolo, I would like paravirq irq_domain to be useful for many hypervisors, not only for one developed by Positive Technologies. It seems to me that the idea of an irq_domain for interrupts injected by a hypervisor is quite generic. I don't like such a way of initializing paravirq_chip very much too. But to my mind, putting some custom hypervisor API to the generic code in Linux kernel mainline is less attractive. Can we find another solution? Thank you. Best regards, Alexander -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
