On 16/07/2016 02:50, Bandan Das wrote: >> > + int ret = setup_shadow_vmcs(vmx); >> > + if (ret) >> > + return ret; > Nit: > if (setup_shadow_vmcs(vmx)) > return -ENOMEM; Nope, -errno is a much better return value than bool, because you never know if bool means success or failure. Jim's patch got it right. :) Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html