On 14/07/16 11:19, Dan Carpenter wrote:
> My static checker complains that this condition looks like it should be
> == instead of =. This isn't a fast path, so we don't need to be fancy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c
> index a57d650..b0b225c 100644
> --- a/arch/arm64/kvm/sys_regs.c
> +++ b/arch/arm64/kvm/sys_regs.c
> @@ -1546,7 +1546,7 @@ static void unhandled_cp_access(struct kvm_vcpu *vcpu,
> struct sys_reg_params *params)
> {
> u8 hsr_ec = kvm_vcpu_trap_get_class(vcpu);
> - int cp;
> + int cp = -1;
>
> switch(hsr_ec) {
> case ESR_ELx_EC_CP15_32:
> @@ -1558,7 +1558,7 @@ static void unhandled_cp_access(struct kvm_vcpu *vcpu,
> cp = 14;
> break;
> default:
> - WARN_ON((cp = -1));
> + WARN_ON(1);
> }
>
> kvm_err("Unsupported guest CP%d access at: %08lx\n",
>
Indeed, that looks a bit dodgy. I'll queue it for 4.8.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
