Hi, On 06/07/16 09:47, Eric Auger wrote: > on ARM, a devid field is populated in kvm_msi struct in case the > flag is set to KVM_MSI_VALID_DEVID. Let's propagate both flags and > devid field in kvm_kernel_irq_routing_entry. > > Signed-off-by: Eric Auger <eric.auger@xxxxxxxxxx> > Acked-by: Christoffer Dall <christoffer.dall@xxxxxxxxxx> So apart from the renaming part I mentioned in the previous patch: Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx> > > --- > v4 -> v5: > - Add Christoffer's R-b > > v2 -> v3: > - do not set the type to KVM_IRQ_ROUTING_EXTENDED_MSI anymore as > suggested by Andre > - correct msi->flags check > - propagate the flags > --- > virt/kvm/irqchip.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c > index 8db197b..32e5646 100644 > --- a/virt/kvm/irqchip.c > +++ b/virt/kvm/irqchip.c > @@ -62,12 +62,14 @@ int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) > { > struct kvm_kernel_irq_routing_entry route; > > - if (!irqchip_in_kernel(kvm) || msi->flags != 0) > + if (!irqchip_in_kernel(kvm) || (msi->flags & ~KVM_MSI_VALID_DEVID)) > return -EINVAL; > > route.msi.address_lo = msi->address_lo; > route.msi.address_hi = msi->address_hi; > route.msi.data = msi->data; > + route.flags = msi->flags; > + route.devid = msi->devid; > > return kvm_set_msi(&route, kvm, KVM_USERSPACE_IRQ_SOURCE_ID, 1, false); > } > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html