On 29/06/16 22:51, Paolo Bonzini wrote: > > On 29/06/2016 06:44, Suraj Jitindar Singh wrote: >> Thanks for catching that, yeah I see. >> >> I don't think we can trivially move the struct kvmppc_vcore definition into >> kvm_book3s.h as other code in kvm_host.h (i.e. struct kvm_vcpu_arch) requires >> the definition. I was thinking that I could just put runnable_threads inside an #ifdef. >> >> #ifdef CONFIG_KVM_BOOK3S_HV_POSSIBLE >> struct kvm_vcpu *runnable_threads[MAX_SMT_THREADS]; >> #endif > You can rename MAX_SMT_THREADS to BOOK3S_MAX_SMT_THREADS and move it to > kvm_host.h. It seems like assembly code does not use it, so it's > unnecessary to have it in book3s_asm.h. It looks like MAX_SMT_THREADS is used else where in book3s_asm.h. I think the easiest option is to put the v_core struct in book3s.h. > > Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
