2016-07-08 10:52+0200, Andrew Jones: > On Fri, Jul 08, 2016 at 10:16:53AM +0200, Auger Eric wrote: >> On 07/07/2016 19:20, Andrew Jones wrote: >> > On Wed, Jul 06, 2016 at 10:47:53AM +0200, Eric Auger wrote: >> >> diff --git a/virt/kvm/irqchip.c b/virt/kvm/irqchip.c >> >> @@ -29,7 +29,9 @@ >> >> #include <linux/srcu.h> >> >> #include <linux/export.h> >> >> #include <trace/events/kvm.h> >> >> +#if !defined(CONFIG_ARM) && !defined(CONFIG_ARM64) >> >> #include "irq.h" >> >> +#endif >> > >> > Instead of doing this, shouldn't we add arch/arm[64]/kvm/irq.h files. >> > Probably a simple one like ./arch/s390/kvm/irq.h ? >> >> Well I considered this solution in the past but I did not find much to >> put there (it was even void). typically irqchip_in_kernel is in >> include/kvm/arm_vgic.h since the macro can be shared between arm/arm64. > > I think I'd prefer a nearly empty file to the #ifdef's, but Paolo and > Radim should chime in. I concur, hiding ugliness in header files is what we strive for. The files could #include <include/kvm/arm_vgic.h>, which might make their existence easier to understand. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
