On 01/07/2016 17:43, Radim Krčmář wrote: > > Forgot to reply about this: letting SET_LAPIC change x2APIC IDs is nonsense. > > > > In x2APIC mode + new capability disabled SET_LAPIC should ignore the id > > register altogether for backwards compatibility. > > I'd still shift SET_LAPIC APIC ID to have internal APIC ID register in > hardware-compatible format. With the capability disabled, APIC ID should always be in bits 31-24 for both GET and SET. But I think we agree, it's simpler to reason in v2 code and testcases. :) Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html