Re: [kvm-unit-tests PATCH v3 0/3] arm/powerpc: make argv[0] the program name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 14, 2016 at 04:45:31PM +0200, Paolo Bonzini wrote:
> 
> 
> On 14/06/2016 16:40, Andrew Jones wrote:
> > 
> > Hi Paolo,
> > 
> > Can you take a look at this series?
> 
> Yes, I wanted to find a little tomorrow to push x86 argv down by one
> item and then apply it.

ping?

Thanks,
drew
> 
> Paolo
> 
> > Thanks,
> > drew
> > 
> > 
> > On Sun, Jun 12, 2016 at 07:29:28PM +0200, Andrew Jones wrote:
> >> v3:
> >>  - fixed x86 compilation by adding a weak symbol for auxinfo
> >>  - reworked all patches to avoid the ugly, although temporary, #ifdeffery
> >>  - also squashed patches 3/4 and 4/4 together
> >>  - moved initializer out of for() [Thomas]
> >>  - dropped all of Thomas' r-b's, as I changed too much to keep
> >>    them, but he shouldn't need to review much of the two "reserve..."
> >>    patches again.
> >>
> >> repost:
> >>  - rebased to latest upstream master (fixed trivial conflicts
> >>    with 4c6b5d and dc0a22, the Makefile cleanup patches)
> >>  - added Thomas' r-b's
> >> v2:
> >>  - copy auxinfo.prognam into argv[0] [drew]
> >>
> >>
> >> It just came to my attention that x86 has the normal argv[0], the
> >> program name, thanks to seabios. That raised the priority of fixing
> >> one of my pet peeves - arm and powerpc starting arguments
> >> at argv[0], as that just ain't right. This series fixes that. A few
> >> temporary hacks are used to avoid one big patch fixing both arm
> >> and powerpc at the same time. The hacks are gone by the end of the
> >> series.
> >>
> >>
> >> Andrew Jones (3):
> >>   arm/arm64: reserve argv[0] for prognam
> >>   powerpc/ppc64: reserve argv[0] for prognam
> >>   arm & powerpc: populate argv[0] with prognam
> >>
> >>  arm/Makefile.common     |  6 +++++-
> >>  arm/selftest.c          | 14 +++++++-------
> >>  arm/spinlock-test.c     |  2 +-
> >>  lib/argv.c              | 27 +++++++++++++++++++++++----
> >>  lib/arm/setup.c         |  4 ++--
> >>  lib/auxinfo.c           |  2 ++
> >>  lib/auxinfo.h           |  7 +++++++
> >>  lib/powerpc/setup.c     |  4 ++--
> >>  powerpc/Makefile.common |  6 +++++-
> >>  powerpc/emulator.c      |  2 +-
> >>  powerpc/rtas.c          | 12 ++++++------
> >>  powerpc/selftest.c      |  8 ++++----
> >>  powerpc/spapr_hcall.c   |  6 +++---
> >>  scripts/auxinfo.mak     |  7 +++++++
> >>  x86/Makefile.common     |  1 +
> >>  15 files changed, 76 insertions(+), 32 deletions(-)
> >>  create mode 100644 lib/auxinfo.c
> >>  create mode 100644 lib/auxinfo.h
> >>  create mode 100755 scripts/auxinfo.mak
> >>
> >> -- 
> >> 2.4.11
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe kvm" in
> >> the body of a message to majordomo@xxxxxxxxxxxxxxx
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux