On Tue, 2009-04-21 at 20:21 +0300, Avi Kivity wrote: > Hollis Blanchard wrote: > > On Tue, 2009-04-21 at 10:08 +0000, Avi Kivity wrote: > > > >> From: Xiantao Zhang <xiantao.zhang@xxxxxxxxx> > >> > >> ia64 depends on platform provides synced idcache after DMA operation. > >> For virtual dma operations in qemu, it also need to provide similar > >> machanism. > >> > >> Signed-off-by: Xiantao Zhang <xiantao.zhang@xxxxxxxxx> > >> Signed-off-by: Avi Kivity <avi@xxxxxxxxxx> > >> > > > > I pointed out some problems with this patch a couple weeks ago: > > http://article.gmane.org/gmane.comp.emulators.kvm.devel/30475 > > > > Why was it still applied? > > > > So I can release kvm-85. I don't like it either. You don't need to commit it: 1. KVM on ia64 has made it for this long without that patch. 2. The ia64 guys didn't even reply, much less revise the patch. 3. The patch quality is clearly not high enough to be committed to qemu (at least, one would hope), so you're just going to have to revert it to apply a better fix anyways. I don't see why all ia64 patches had to be applied for kvm-85, regardless of merit. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
