On Mon, Jun 13, 2016 at 03:34:53PM +0200, Paolo Bonzini wrote:
>
>
> On 13/06/2016 12:49, Andrew Jones wrote:
> >> +
> >> +#ifndef mb
> >> +#define mb() asm volatile("":::"memory")
> >> +#endif
> >> +#ifndef rmb
> >> +#define rmb() asm volatile("":::"memory")
> >> +#endif
> >> +#ifndef wmb
> >> +#define wmb() asm volatile("":::"memory")
> >> +#endif
>
> This is certainly wrong for PPC64.
Using the generic ones is good enough for ppc64 for now,
since it doesn't use them. As soon as it's necessary to have
proper barriers, then lib/ppc64/asm/barrier.h should be
updated to stop including this, and to define their own.
Actually we could drop the ppc64 barrier.h patch for now,
but that relies on the compiler not generating unused code,
otherwise including asm-generic/io.h would break compilation.
Thanks,
drew
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
