On Wed, Jun 08, 2016 at 03:58:07AM -0400, Paolo Bonzini wrote: > > > We have page constants defined this way for every other arch: > > > > lib/arm/asm/page.h > > lib/arm64/asm/page.h > > lib/asm-generic/page.h (covers ppc64) > > > > Why not to bring x86 in line also? > > The bug is in the others. :) There's no reason for kvm-unit-tests to > depend on Linux, and PAGE_SIZE is never used in assembly either. kvm-unit-tests isn't depending on linux when including <linux/...>. We have our own copies of a few Linux uapi headers in there, like const.h. We may not use PAGE_SIZE in assembly yet, but it's certainly a reasonable thing to expect to do some day. Look at the linux source $ git grep PAGE_SIZE | grep '\.S:' | wc -l 459 drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
