On 06/07/16 17:10, Eduardo Habkost wrote: > On Fri, Jun 03, 2016 at 02:09:43PM +0800, Haozhong Zhang wrote: > [...] > > + > > + if (cpu->enable_lmce) { > > + if (lmce_supported()) { > > + cenv->mcg_cap |= MCG_LMCE_P; > > + cenv->msr_ia32_feature_control |= > > + MSR_IA32_FEATURE_CONTROL_LMCE | > > + MSR_IA32_FEATURE_CONTROL_LOCKED; > > + } else { > > + error_report("Warning: KVM unavailable or not support LMCE, " > > + "LMCE disabled"); > > + cpu->enable_lmce = false; > > Please don't do that. If the user explicitly asked for LMCE, you > should refuse to start if the host doesn't have the required > capabilities. > OK, I'll change in the next version. Thanks, Haozhong > > > + } > > + } > > + > > cenv->mcg_ctl = ~(uint64_t)0; > > for (bank = 0; bank < MCE_BANKS_DEF; bank++) { > > cenv->mce_banks[bank * 4] = ~(uint64_t)0; > [...] > > -- > Eduardo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html