Re: [PATCH] scripts/runtime: Adjust the premature_failure check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 31/05/2016 17:56, Radim Krčmář wrote:
> 2016-05-31 17:37+0200, Radim Krčmář:
>> 2016-05-31 12:54+0200, Lukáš Doktor:
>>> The premature_failure check fails on qemu-system-ppc64 as it uses
>>> different message. This patch modifies the condition so it works
>>> (hopefully) for all archs.
>>> ---
>>> diff --git a/scripts/runtime.bash b/scripts/runtime.bash
>>> -    echo "$last_line" | grep -qi "could not load kernel" &&
>>> +    echo "$last_line" | grep "_NO_FILE_4Uhere_" | grep -qi "no such file" &&
>>
>> PPC uses "Could not open '_NO_FILE_4Uhere_': No such file [...]".
>> The problem is that "No such file [...]" might be localized, so what
>> about
>>   grep -qi "could not \(load kernel\|open\) '_NO_FILE_4Uhere_'"
>> ?
> 
> My tested local repo has a different line there:
> (no idea how the posted version came around ...)
> 
>   echo "$last_line" | grep -qi "_NO_FILE_4Uhere_" &&

"-i" is not needed here, though.

Paolo

> so we might be fine with it too, but I like the context check.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux