On Fri, Apr 22, 2016 at 07:07:29PM +0200, Andrew Jones wrote: > > +static u64 pci_alloc_res(struct pci_host_bridge *host, int type, u64 size) [...] > > + size = ALIGN(size, mask); > > + assert(as->free + size <= as->size); > > + > > + addr = as->pci_start + as->free; > > + as->free += size; > > Hmm, the name 'free' made me think it was pointing at the start > of free memory, but it's just an offset. Maybe a name like free_offset > would be better? Or initialize it to as->pci_start and use it as > a free pointer? Whatever though, not a big deal. It is also not an offset per se. It is rather number of already allocated bytes. What about "allocated"? > > + > > + return addr; > > +} > Thanks, > drew -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
