On 23.05.2016 13:42, Paolo Bonzini wrote: > > On 23/05/2016 13:22, David Binderman wrote: >> Hello there, >> >> arch/x86/kvm/svm.c:3600:45: warning: logical ‘and’ applied to >> non-boolean constant [-Wlogical-op] >> >> Source code is >> >> u32 index = svm->vmcb->control.exit_info_2 && 0xFF; >> >> Maybe better code >> >> u32 index = svm->vmcb->control.exit_info_2 & 0xFF; > > Yes, there's a bug there. However it's only affecting a tracepoint, > which is why it probably wasn't noticed. This define in the same file also looks quite suspicious: #define AVIC_HPA_MASK ~((0xFFFULL << 52) || 0xFFF) Strange that you did not get a warning on that one, too? Thomas -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
