On Wed, May 18, 2016 at 02:49:48PM -0700, Steve Rutherford wrote: > This patch looks good. > > I don't believe you need to explicitly check virtualize x2apic mode, > given that `vcpu->arch.apic_base & X2APIC_ENABLE && > kvm_vcpu_apicv_active(vcpu)` implies that virtualize x2apic mode is > enabled (because KVM currently never re-enables apicv after disabling > it with the SyncIC), but being explicit is probably easier to > maintain. This was exactly my intent. Thanks, Roman. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html